fix(settings): improve shortcuts reset button hover and tile layout #8435
+29
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved keyboard height calculation to prioritize viewInsets.bottom when keyboard is visible - Added 8px safety margin on Android to account for keyboard toolbar - Ensures toolbar stays visible above the keyboard in all scenarios Fixes AppFlowy-IO#8433
…O#8222) - Add hover effect to reset button (icon and text change to primary color) - Change shortcut tile layout from Expanded to Flexible for better spacing - Fixes inconsistent button hover behavior - Improves visual alignment by reducing blank space in shortcut tiles
|
|
Contributor
Reviewer's GuideAdjusts Android mobile toolbar keyboard height handling for more accurate positioning above the keyboard and improves the Settings > Shortcuts reset button hover state and tile layout to prevent text overflow and keep controls aligned. Sequence diagram for updated Android keyboard height handling in mobile toolbarsequenceDiagram
actor User
participant FlutterFramework
participant MobileToolbarState
participant MediaQuery
User->>FlutterFramework: Focuses text field (Android)
FlutterFramework->>MobileToolbarState: onKeyboardHeightChanged(height)
MobileToolbarState->>MobileToolbarState: keyboardHeight = height
alt Platform is android and not showingMenu
MobileToolbarState->>MediaQuery: get viewInsetsBottom
MediaQuery-->>MobileToolbarState: viewInsetsBottom
alt viewInsetsBottom > 0
MobileToolbarState->>MobileToolbarState: keyboardHeight = viewInsetsBottom
else viewInsetsBottom <= 0
MobileToolbarState->>MobileToolbarState: keyboardHeight = max(keyboardHeight, viewInsetsBottom)
end
end
alt keyboardHeight > 0
MobileToolbarState->>MobileToolbarState: _globalCachedKeyboardHeight = keyboardHeight
alt Platform is android
MobileToolbarState->>MobileToolbarState: keyboardHeight += 8.0
end
end
MobileToolbarState-->>FlutterFramework: return SizedBox(height: keyboardHeight)
FlutterFramework-->>User: Toolbar positioned above keyboard
Updated class diagram for mobile toolbar keyboard handling and shortcuts settings widgetsclassDiagram
class _MobileToolbarState {
+double _globalCachedKeyboardHeight
+Widget build(BuildContext context)
+void onKeyboardHeightChanged(double height)
}
class _ResetButton {
+VoidCallback onReset
+Widget build(BuildContext context)
}
class FlowyHover {
+HoverStyle style
+Widget Function(BuildContext context, bool isHovering) builder
}
class HoverStyle {
+Color hoverColor
+BorderRadius borderRadius
}
class _ShortcutSettingTileState {
+Widget build(BuildContext context)
}
_MobileToolbarState --> _ShortcutSettingTileState : same_screen_usage
_ResetButton --> FlowyHover : wraps
FlowyHover --> HoverStyle : uses
_ShortcutSettingTileState --> _ResetButton : contains
_MobileToolbarState --> MediaQuery : reads_viewInsetsBottom
class MediaQuery {
+EdgeInsets viewInsets
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the Android keyboard handling logic, the
elsebranch that is supposed to "use cached height when keyboard is hiding" currently just doeskeyboardHeight = max(keyboardHeight, viewInsetsBottom)(whereviewInsetsBottomis 0), so it never actually uses_globalCachedKeyboardHeight; consider using the cached value there or updating the comment/logic for clarity. - You add the 8.0 safety margin to
keyboardHeightafter updating_globalCachedKeyboardHeight, so the cached value and the actual used height diverge; consider whether the safety margin should also be reflected in the cached value or applied consistently wherever the cache is consumed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the Android keyboard handling logic, the `else` branch that is supposed to "use cached height when keyboard is hiding" currently just does `keyboardHeight = max(keyboardHeight, viewInsetsBottom)` (where `viewInsetsBottom` is 0), so it never actually uses `_globalCachedKeyboardHeight`; consider using the cached value there or updating the comment/logic for clarity.
- You add the 8.0 safety margin to `keyboardHeight` after updating `_globalCachedKeyboardHeight`, so the cached value and the actual used height diverge; consider whether the safety margin should also be reflected in the cached value or applied consistently wherever the cache is consumed.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Preview
PR Checklist
Summary by Sourcery
Improve Android mobile toolbar positioning relative to the keyboard and refine the Settings shortcuts UI behavior and layout.
New Features:
Bug Fixes:
Enhancements: