Skip to content

Fix Studio site crashing when rotatePHPRuntime was executed #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sejas merged 2 commits into from
Mar 6, 2025
Merged

Fix Studio site crashing when rotatePHPRuntime was executed #1019

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b161137
avoid creating hello wp-now virtual index.php
sejas Mar 6, 2025
8f1936b
avoid initializing Playground and mounting direcotries again when PHP…
sejas Mar 6, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions vendor/wp-now/src/wp-now.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,7 @@ export default async function startWPNow(
cwd: requestHandler.documentRoot,
recreateRuntime: async () => {
output?.log( 'Recreating and rotating PHP runtime' );
const { php, runtimeId } = await getPHPInstance( options, true, requestHandler );
await prepareDocumentRoot( php, options );
await prepareWordPress( php, options );
const { runtimeId } = await getPHPInstance( options, true, requestHandler );
return runtimeId;
},
maxRequests: 400,
Expand Down Expand Up @@ -166,7 +164,6 @@ async function getPHPInstance(
async function prepareDocumentRoot( php: PHP, options: WPNowOptions ) {
php.mkdir( options.documentRoot );
php.chdir( options.documentRoot );
php.writeFile( `${ options.documentRoot }/index.php`, `<?php echo 'Hello wp-now!';` );
php.writeFile(
path.posix.join( PLAYGROUND_INTERNAL_SHARED_FOLDER, 'ca-bundle.crt' ),
rootCertificates.join( '\n' )
Expand Down