Skip to content

Fix cropped focus outline style for sidebar buttons - #102

Merged
SiobhyB merged 1 commit into
trunkfrom
fix/ensure-focus-style-visibility-in-sidebar
May 8, 2024
Merged

Fix cropped focus outline style for sidebar buttons#102
SiobhyB merged 1 commit into
trunkfrom
fix/ensure-focus-style-visibility-in-sidebar

Conversation

@SiobhyB

@SiobhyB SiobhyB commented May 8, 2024

Copy link
Copy Markdown

Related to #82 (review)

Proposed Changes

  • The focus outline style for the sidebar buttons is slightly cropped on the left. The reason for this is that the changes in Ensure only bordering areas of app are draggable #82 removed the button's left margin, leaving no longer space for the extra border to be displayed.
  • With this PR, a small amount of left margin is added back to the buttons (this is then subtracted from the main sidebar).

Testing Instructions

  • Navigate through the app using your keyboard and verify that the focus outline style appears as expected, no longer cropped.
  • In addition, verify that it's still possible to drag the left border and that the amount of space it's possible to drag isn't noticeably smaller.
Before After

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@SiobhyB SiobhyB self-assigned this May 8, 2024
@SiobhyB
SiobhyB marked this pull request as ready for review May 8, 2024 09:57
@SiobhyB
SiobhyB requested a review from a team May 8, 2024 09:57

@dcalhoun dcalhoun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this! 🚀

@SiobhyB
SiobhyB merged commit 999d718 into trunk May 8, 2024
@SiobhyB
SiobhyB deleted the fix/ensure-focus-style-visibility-in-sidebar branch May 8, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants