Skip to content

Update tooltips in the new Previews tab (redo) #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wojtekn merged 3 commits into from
Mar 7, 2025
Merged

Update tooltips in the new Previews tab (redo) #1027

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eacc1ee
Update tooltips in site previews.
ndiego Feb 28, 2025
e9bc387
Add back link tooltips and standardize with Sync tab..
ndiego Mar 4, 2025
ec3e4a5
Linting.
ndiego Mar 5, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add back link tooltips and standardize with Sync tab..
  • Loading branch information
@ndiego
ndiego committed Mar 4, 2025
commit e9bc3879eaa0691c88c30b195daa33ae8aea174b
10 changes: 8 additions & 2 deletions src/components/sync-connected-sites.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,14 @@ const SyncConnectedSitesSection = ( {
<Badge className="bg-a8c-green-5 text-a8c-green-80">{ __( 'Production' ) }</Badge>
) }
</div>

<Tooltip text={ connectedSite.url } className="overflow-hidden">
<Tooltip
text={ sprintf(
/* translators: %s: The URL of the connected site */
__( 'Open %s' ),
connectedSite.url
) }
className="overflow-hidden"
>
<Button
variant="link"
className="!text-a8c-gray-70 hover:!text-a8c-blueberry max-w-[100%]"
Expand Down
34 changes: 22 additions & 12 deletions src/modules/preview-site/components/preview-site-row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,20 +117,30 @@ export function PreviewSiteRow( {
{ snapshot.name || sprintf( __( '%s Preview' ), selectedSite.name ) }
</div>
</div>
<Button
variant="link"
disabled={ isExpired }
className={ cx(
'!text-a8c-gray-700 max-w-full',
isExpired ? 'pointer-events-none' : 'hover:!text-a8c-blueberry'
<Tooltip
text={ sprintf(
/* translators: %s: The preview site URL */
__( 'Open %s' ),
urlWithHTTPS
) }
onClick={ () => getIpcApi().openURL( urlWithHTTPS ) }
disabled={ isExpired }
className="overflow-hidden"
>
<span className={ cx( 'truncate', isExpired && 'line-through text-a8c-gray-700' ) }>
{ urlWithHTTPS }
</span>
{ ! isExpired && <ArrowIcon /> }
</Button>
<Button
variant="link"
disabled={ isExpired }
className={ cx(
'!text-a8c-gray-700 max-w-full',
isExpired ? 'pointer-events-none' : 'hover:!text-a8c-blueberry'
) }
onClick={ () => getIpcApi().openURL( urlWithHTTPS ) }
>
<span className={ cx( 'truncate', isExpired && 'line-through text-a8c-gray-700' ) }>
{ urlWithHTTPS }
</span>
{ ! isExpired && <ArrowIcon /> }
</Button>
</Tooltip>
</div>
<div className="flex ltr:ml-auto rtl:mr-auto">
<div className="w-[150px] text-a8c-gray-700 flex items-center pl-4">
Expand Down