Update header styles - #105
Merged
Merged
Conversation
Contributor
|
I had started reviewing, and noted that the PR is still in a draft state. Off to a good start anyways, the updated styles look great so far. 👍 Feel free to ping when ready for review. |
matt-west
marked this pull request as ready for review
May 9, 2024 08:09
Contributor
Author
|
Thanks @derekblank. This is now ready for review. |
derekblank
approved these changes
May 9, 2024
derekblank
left a comment
derekblank
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I tested on RTL and LTR layouts using varied long and short site titles, and observed that the header styles matched the updated "After" screenshot. 🚀
wojtekn
approved these changes
May 9, 2024
wojtekn
left a comment
wojtekn
left a comment
Contributor
There was a problem hiding this comment.
The code change looks clear, works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/Automattic/dotcom-forge/issues/6977
Proposed Changes
gray 70for header links, andblueberryon hover.Testing Instructions
Pre-merge Checklist