Custom Domain: Allow updating domains for existing sites.

[youknowriad]

Related issues

• Fixes Feature Request: Allow modifying the custom domain of a given site #1053
• Fixes STU-72-linear-issue

Summary

• Adds ability to add, modify, or remove custom domains on existing sites
• Ensures consistent domain validation and handling across site creation and editing
• Ensures we update the hosts file and the database content when the domain is updated.

Testing instructions

• Create a site (once with a custom domain, and once without)
• Try updating domains for running and stopped sites

[youknowriad]

Can I get some reviews here?

[bcotrim]

Great feature!
Added some comments, but overall I think this looks great!

Something I noticed during my tests:

• Having an invalid domain disables the submit, even when "Use custom domain" isn't checked. I recorded on "Edit Site" but the same behavior happens on "Add Site":

Screen.Recording.2025-03-19.at.18.28.37.mov

[bcotrim]

I would rename this function as it handles all possible domain change scenarios.

And to keep the format consistent, move the replacing logic to its own replaceDomainInHosts

[youknowriad]

Not sure I understand this comment fully but I renamed the function.

[bcotrim]

It seems a lot of this logic is very similar to the one we added to site-form
I believe there's an opportunity here to create a shared component/hook, to avoid repetition.

[youknowriad]

Entirely agree but this is not new. The way the form works today is not great and would deserve a refactor but it's not a small change.

[youknowriad]

I fixed the validation bug.

[bcotrim]

Thanks for making the changes.
I added a small comment, but it shouldn't be blocking.

I noticed the custom domain error message get cut when we display multiple errors.
This should be fixed with this change but something to re-test later.

[wojtekn]

Having an invalid domain disables the submit, even when "Use custom domain" isn't checked. I recorded on "Edit Site" but the same behavior happens on "Add Site":

@bcotrim I tested it when I rebased #1078 and noticed it is fixed in Add Site, but it still happens in Edit Site. Are you also reproduce it there?

[bcotrim]

Having an invalid domain disables the submit, even when "Use custom domain" isn't checked. I recorded on "Edit Site" but the same behavior happens on "Add Site":

@bcotrim I tested it when I rebased #1078 and noticed it is fixed in Add Site, but it still happens in Edit Site. Are you also reproduce it there?

I don't see it happening on "Add Site" or "Edit Site".
Note that if you don't have any change compared the existing settings the button is still disabled due to the form being unchanged, not the validation error.

Screen.Recording.2025-03-21.at.10.01.25.mov

[wojtekn]

Note that if you don't have any change compared the existing settings the button is still disabled due to the form being unchanged, not the validation error.

Oh, it was that. Thanks for clarifying. When I edit the site name, then enable a custom domain and enter an invalid one, Save button toggles correctly when I keep disabling and enabling a custom domain.