Skip to content

Improve error message when port 80 is already in use #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivan-ottinger merged 4 commits into from
Mar 17, 2025
Merged

Improve error message when port 80 is already in use #1068

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44bbd98
Delay error message
ivan-ottinger Mar 14, 2025
222e258
Update error message
ivan-ottinger Mar 14, 2025
245e28e
Update copy
ivan-ottinger Mar 14, 2025
da29638
Pass `mainWindow` instance to `dialog.showMessageBox` instead of usin…
ivan-ottinger Mar 14, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/lib/proxy-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { domainToASCII } from 'node:url';
import * as Sentry from '@sentry/electron/main';
import { __ } from '@wordpress/i18n';
import httpProxy from 'http-proxy';
import { getMainWindow } from 'src/main-window';
import { SiteServer } from 'src/site-server';
import { loadUserData } from 'src/storage/user-data';

Expand Down Expand Up @@ -97,11 +98,12 @@ export async function startProxyServer(): Promise< boolean > {
return true;
} catch ( error ) {
if ( error instanceof Error && 'code' in error && error.code === 'EADDRINUSE' ) {
dialog.showMessageBox( {
const mainWindow = await getMainWindow();
dialog.showMessageBox( mainWindow, {
type: 'error',
message: __( 'Failed to start custom domain proxy server' ),
message: __( 'Custom domain set up failed' ),
detail: __(
'Another server is already running on port 80. For custom domains to work, please stop that server and then restart Studio.'
'Studio needs to use port 80, but it’s already in use by another app. Close any local development apps and restart Studio.'
),
buttons: [ __( 'OK' ) ],
} );
Expand Down