Skip to content

Increase site server process timeout for messages - #108

Merged
wojtekn merged 1 commit into
trunkfrom
fix/timeout-site-server-process-messages
May 10, 2024
Merged

Increase site server process timeout for messages#108
wojtekn merged 1 commit into
trunkfrom
fix/timeout-site-server-process-messages

Conversation

@fluiddot

@fluiddot fluiddot commented May 9, 2024 •
edited by wojtekn
Loading

Copy link
Copy Markdown
Contributor

Related issue: https://github.com/Automattic/dotcom-forge/issues/7061

Proposed Changes

  • Increase the timeout duration for waiting for messages from the site server process. This adjustment ensures that sites can be created successfully even if the process takes longer than anticipated. Notably, on Windows, site creation can occasionally require up to 30 seconds.

Testing Instructions

  • Open the app on Windows (it's recommended that it's a medium/slow machine).
  • Create a site.
  • Observe the site is created.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@fluiddot
fluiddot requested review from a team May 9, 2024 15:56
@fluiddot fluiddot self-assigned this May 9, 2024
wojtekn
wojtekn approved these changes May 10, 2024
View reviewed changes

@wojtekn wojtekn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to add a few sites on Windows and all were added successfully, without an error.
@wojtekn
wojtekn merged commit 1710b27 into trunk May 10, 2024
@wojtekn
wojtekn deleted the fix/timeout-site-server-process-messages branch May 10, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@fluiddot @wojtekn