Remove arrow and improve button CTA on Onboarding screen - #111
Merged
Conversation
derekblank
approved these changes
May 10, 2024
derekblank
left a comment
Contributor
There was a problem hiding this comment.
LGTM. 🚀 I observed that:
- The non-interactable arrow was removed from the Onboarding screen
- The "Continue" button text was updated to "Add site"
- When adding a site, the "Adding site..." text replaced the updated button text as intended
- The "Add site" button text was translated with i18n
- The layout worked as expected for RTL and LTR locales
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/Automattic/dotcom-forge/issues/7004
Proposed Changes
I propose to reduce the confusion we observed on the Onboarding screen:
Testing Instructions
appdata-v1.jsonfile with emptied sites)Pre-merge Checklist