Skip to content

Remove arrow and improve button CTA on Onboarding screen - #111

Merged
wojtekn merged 1 commit into
trunkfrom
update/remove-arrow-from-onboarding
May 10, 2024
Merged

Remove arrow and improve button CTA on Onboarding screen#111
wojtekn merged 1 commit into
trunkfrom
update/remove-arrow-from-onboarding

Conversation

@wojtekn

@wojtekn wojtekn commented May 10, 2024

Copy link
Copy Markdown
Contributor

Related to https://github.com/Automattic/dotcom-forge/issues/7004

Proposed Changes

I propose to reduce the confusion we observed on the Onboarding screen:

  • remove the are that looks like CTA but is not
  • change 'Continue' to 'Add site' to make CTA clearer and consistent with the other form

Testing Instructions

  1. Remove all sites (or use an appdata-v1.json file with emptied sites)
  2. Start the Studio
  3. Confirm there is no arrow on left side
  4. Confirm CTA is now 'Add site'
Screenshot 2024-05-10 at 08 46 11

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@wojtekn
wojtekn requested review from a team May 10, 2024 06:51
@wojtekn wojtekn self-assigned this May 10, 2024

@derekblank derekblank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀 I observed that:

  • The non-interactable arrow was removed from the Onboarding screen
  • The "Continue" button text was updated to "Add site"
  • When adding a site, the "Adding site..." text replaced the updated button text as intended
  • The "Add site" button text was translated with i18n
  • The layout worked as expected for RTL and LTR locales
@wojtekn
wojtekn merged commit 101d98d into trunk May 10, 2024
@wojtekn
wojtekn deleted the update/remove-arrow-from-onboarding branch May 10, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants