Site updates: Regenerate domain certificate when the domain is changed - #1116
Merged
Conversation
ivan-ottinger
approved these changes
Mar 25, 2025
ivan-ottinger
left a comment
Contributor
There was a problem hiding this comment.
The proposed changes look good and work as expected. 👌🏼
- changing and renaming domain works correctly
- disabling HTTPS or removing a site removes the related certificate from the file system
- I did not observe any regressions
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related STU-19-linear-issue
Proposed Changes
This PR fixes a couple small bugs and makes a small related refactoring:
Testing Instructions
On each step, the site should function properly (assuming the root certificate is trusted)