Studio: Remove ability to dismiss the warning when pushing to a production site - #1168
Merged
Merged
Conversation
ivan-ottinger
approved these changes
Apr 7, 2025
ivan-ottinger
left a comment
ivan-ottinger
left a comment
Contributor
There was a problem hiding this comment.
The proposed change looks good and works as expected. 👍🏼
The confirmation checkbox is no longer rendered when pushing to a production WPCOM site.
The users will be now asked to confirm the production push action even if they have disabled the modal from displaying previously.
Contributor
|
Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Closes STU-322
Proposed Changes
This PR allows ensures that the user can not dismiss the warning to not show again when they are trying to push to a production site. It should be possible though to dismiss the warning when pushing to a staging site.
Testing Instructions
You might also need to clear your local storage in the Application tab in the Chrome dev tools if you previously dismissed this warning to test the changes on this branch.
npm startSynctabPushby a production sitePushby a staging sitePre-merge Checklist