Studio: Ensure that buttons in the footer are the same size - #1174
Merged
katinthehatsite merged 1 commit intoApr 8, 2025
Merged
Conversation
katinthehatsite
commented
Apr 8, 2025
| background: white; | ||
| } | ||
|
|
||
| .components-button.components-guide__finish-button { |
Contributor
Author
There was a problem hiding this comment.
This is not related, just fixing a small linter issue instead of opening a whole new PR for it
ivan-ottinger
approved these changes
Apr 8, 2025
ivan-ottinger
left a comment
ivan-ottinger
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Both buttons have the same height now. 👌🏼
katinthehatsite
deleted the
fix/ensure-all-modal-buttons-have-consistent-height
branch
April 8, 2025 12:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Closes STU-325
Proposed Changes
This PR ensures that the
PreviousandNext/Donebuttons have the same height in theWhat's newmodal.Previously, the buttons did use the same height but the
Previousbutton had an outline added to it which added 2 extra pixels (1 to the top and 1 to the bottom) and made it look slightly bigger. I propose to remove the outline and use border instead to make sure it is included in the box model and is not added on the top of the button.Testing Instructions
STUDIO_WHATS_NEW_SECTION=true npm startHelp > What's Newin the top barPreviousandNextbuttons look visually the sameSidenote: I tried with Tailwind but it was not going anywhere so I decided to use CSS directly.
Pre-merge Checklist