Improve 'stop all' for long translations - #12
Merged
Conversation
SiobhyB
marked this pull request as ready for review
April 23, 2024 00:25
derekblank
self-requested a review
April 23, 2024 01:30
derekblank
approved these changes
Apr 23, 2024
Contributor
|
Thanks @SiobhyB , looks much better now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Related to 6667-gh-Automattic/dotcom-forge
Proposed Changes
With this PR, some tweaks are made to the 'stop all' button's styles, to ensure it remains visually pleasing with long translations.
Breakdown of the code changes:
shrink-0to ensure the button's content can overflow onto a new line. (Note, this class was first added in 49d1c37 but no longer seems necessary following 756a223.)Testing Instructions
Pre-merge Checklist