Simplify multipart requests by dropping manually encoding - #122
Merged
Conversation
derekblank
approved these changes
May 14, 2024
derekblank
left a comment
derekblank
left a comment
Contributor
There was a problem hiding this comment.
LGTM as well. 🚀
Confirming that this PR resolves the font loading issue described in #110 via these testing steps:
- Created new site
- Opened site editor using a block theme
- Uploaded a font file (Global Styles → Typography → Manage Fonts)
- Observed that request completes successfully and does not hang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to WordPress/playground-tools#261.
Proposed Changes
wp-now(WP-NOW: Simplify multipart requests by dropping manually encoding WordPress/playground-tools#261). This implies dropping manually encoding multipart requests, as suggested in this discussion.Testing Instructions
Pre-merge Checklist