Update Sentry dependencies - #1238
Merged
Merged
Conversation
# Conflicts: # src/modules/user-settings/components/user-settings.tsx
wojtekn
force-pushed
the
update/sentry-dependencies
branch
from
April 22, 2025 10:44
22a077d to
c3f3cd3
Compare
katinthehatsite
approved these changes
Apr 22, 2025
katinthehatsite
left a comment
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
Not sure how to test this, I opened the app, looked through and everything seemed to be correct.
wojtekn
commented
Apr 22, 2025
| }, | ||
| return breadcrumb; | ||
| }, | ||
| reactInit |
Contributor
Author
There was a problem hiding this comment.
When I keep the reactInit, it breaks the renderer. Sentry docs say we can pass it if we use framework specific SDK: Framework-Specific SDKs.
@nightnei could you please advise how to test breadcrumb code with that change?
Contributor
There was a problem hiding this comment.
I can't test it, sicne looks like we have and issue in Sentry with limitations:
Also more info here: p1745411730036399-slack-C04GESRBWKW
gcsecsey
approved these changes
Apr 24, 2025
gcsecsey
left a comment
gcsecsey
left a comment
Member
There was a problem hiding this comment.
Changes LGTM. I tested a clean build with these changes, and Sentry still initializes as on trunk:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Testing Instructions
Pre-merge Checklist