Skip to content

Expand minimum window height with title bar height on Windows - #124

Merged
fluiddot merged 1 commit into
trunkfrom
fix/settings-overlap-draggable-area
May 14, 2024
Merged

Expand minimum window height with title bar height on Windows#124
fluiddot merged 1 commit into
trunkfrom
fix/settings-overlap-draggable-area

Conversation

@fluiddot

@fluiddot fluiddot commented May 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related to 7076-gh-automattic/dotcom-forge.

Proposed Changes

  • Expand the minimum window's height with Windows title bar height. This would ensure that the app's content won't overflow.
Before After

Testing Instructions

  1. Open the app on Windows.
  2. Navigate to Settings tab.
  3. Observe that the content doesn't overflow the app's frame (i.e. no scroll is displayed).
  4. Observe that the "Delete site" button can be clicked.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@fluiddot fluiddot self-assigned this May 14, 2024
@fluiddot
fluiddot marked this pull request as ready for review May 14, 2024 09:00
@fluiddot
fluiddot requested review from a team May 14, 2024 09:00
derekblank
derekblank approved these changes May 14, 2024
View reviewed changes

@derekblank derekblank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀 Using the Windows dev build, I was able to observe:

  • The Settings tab content doesn't overflow the app's frame
  • The "Delete site" button can be clicked
@fluiddot
fluiddot merged commit b8be32b into trunk May 14, 2024
@fluiddot
fluiddot deleted the fix/settings-overlap-draggable-area branch May 14, 2024 09:36
@derekblank derekblank mentioned this pull request May 14, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@fluiddot @derekblank