Sync: Replace site_owner with is_a8c field for filtering out A8C sites - #1262
Merged
Merged
Conversation
gcsecsey
approved these changes
Apr 24, 2025
gcsecsey
left a comment
gcsecsey
left a comment
Member
There was a problem hiding this comment.
LGTM and works well. When using this branch with the sandboxed API, I can only see my own sites in the list! 👌
bcotrim
approved these changes
Apr 24, 2025
bcotrim
left a comment
bcotrim
left a comment
Contributor
There was a problem hiding this comment.
Works as described and code LGTM 👍
Kudos for jumping on this so quickly!
sejas
approved these changes
Apr 24, 2025
sejas
left a comment
sejas
left a comment
Member
There was a problem hiding this comment.
Tested along 181408-ghe-Automattic/wpcom and I confirm it works great.
If is_a8c doesn't exist, it still rendering all sites without any issue.
If you apply the backend change, it filters out A8c sites. Thanks for iterating so fast 👏
Contributor
Author
|
Thank you for your reviews, everyone! 🙇🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
is_a8cinstead ofsite_ownerfield to filter out A8C sitesTesting Instructions
public-api.wordpress.com.npm start.Connect sitebutton.Pre-merge Checklist