Export: Exclude node_modules and .git paths from site export - #1264
Merged
Conversation
ivan-ottinger
commented
Apr 25, 2025
Comment on lines
+233
to
+234
| const isNodeModulesDirectory = relativePath.includes( 'node_modules' ); | ||
| const isGitDirectory = relativePath.includes( '.git' ); |
Contributor
Author
There was a problem hiding this comment.
I think it should be safe to exclude all those paths that include node_modules or .git in them, but happy to make it more strict if you think it's necessary. 🙂
Member
There was a problem hiding this comment.
I agree IMO this should be strict enough! 👌
ivan-ottinger
marked this pull request as ready for review
April 25, 2025 12:35
epeicher
approved these changes
Apr 25, 2025
epeicher
left a comment
epeicher
left a comment
Contributor
There was a problem hiding this comment.
I have tested it, and it works as expected. There are no node_modules or .git folders on the exported site. LGTM! 
| Studio folder | Exported site folder |
|---|---|
 |
 |
gcsecsey
approved these changes
Apr 25, 2025
gcsecsey
left a comment
gcsecsey
left a comment
Member
There was a problem hiding this comment.
Thanks @ivan-ottinger for working on this and for adding such detailed testing steps! 🙌
The changes LGTM and it's working great for me too! Thanks @epeicher for the handy tree listing command, it made screenshotting much easier! 😄
| My site files | exported files |
|---|---|
 |
 |
Comment on lines
+233
to
+234
| const isNodeModulesDirectory = relativePath.includes( 'node_modules' ); | ||
| const isGitDirectory = relativePath.includes( '.git' ); |
Member
There was a problem hiding this comment.
I agree IMO this should be strict enough! 👌
Contributor
Author
|
Thank you for your review, Roberto and Gergely! 🙂 |
gavande1
pushed a commit
that referenced
this pull request
Apr 28, 2025
* Exclude `node_modules` from plugin directories during site export * Remove leftover code * Exclude node_modules and .git directories from file export in a simpler way
sejas
reviewed
Apr 28, 2025
sejas
left a comment
sejas
left a comment
Member
There was a problem hiding this comment.
Great work! I confirm that the .git and node_modules folders, along with all the files inside them, are excluded. This PR changes the behaviour of Sync and Import/Export features.
I left a comment on STU-411 to update docs in Import/Export mentioning that these folders are excluded.
Some logs I've added
----> Excluding wp-content/plugins/node_modules
----> Excluding wp-content/plugins/node_modules/.DS_Store
----> Excluding wp-content/plugins/node_modules/.git
----> Excluding wp-content/plugins/node_modules/yay
----> Excluding wp-content/plugins/node_modules/yay/test.diff
----> Excluding wp-content/plugins/node_modules/.git/test.diff
----> Excluding wp-content/plugins/mine/.git
----> Excluding wp-content/plugins/mine/.git/test.diff
----> Excluding wp-content/mu-plugins/sqlite-database-integration
----> Excluding wp-content/mu-plugins/sqlite-database-integration/LICENSE
----> Excluding wp-content/mu-plugins/sqlite-database-integration/activate.php
----> Excluding wp-content/mu-plugins/sqlite-database-integration/admin-notices.php
----> Excluding wp-content/mu-plugins/sqlite-database-integration/admin-page.php
----> Excluding wp-content/mu-plugins/sqlite-database-integration/constants.php
----> Excluding wp-content/mu-plugins/sqlite-database-integration/db.copy
----> Excluding wp-content/mu-plugins/sqlite-database-integration/deactivate.php
----> Excluding wp-content/mu-plugins/sqlite-database-integration/health-check.php
----> Excluding wp-content/mu-plugins/sqlite-database-integration/load.php
----> Excluding wp-content/mu-plugins/sqlite-database-integration/php-polyfills.php
----> Excluding wp-content/mu-plugins/sqlite-database-integration/readme.txt
----> Excluding wp-content/mu-plugins/sqlite-database-integration/wp-includes
----> Excluding wp-content/mu-plugins/sqlite-database-integration/wp-includes/sqlite
----> Excluding wp-content/mu-plugins/sqlite-database-integration/wp-includes/sqlite/class-wp-sqlite-db.php
----> Excluding wp-content/mu-plugins/sqlite-database-integration/wp-includes/sqlite/class-wp-sqlite-lexer.php
----> Excluding wp-content/mu-plugins/sqlite-database-integration/wp-includes/sqlite/class-wp-sqlite-pdo-user-defined-functions.php
----> Excluding wp-content/mu-plugins/sqlite-database-integration/wp-includes/sqlite/class-wp-sqlite-query-rewriter.php
----> Excluding wp-content/mu-plugins/sqlite-database-integration/wp-includes/sqlite/class-wp-sqlite-token.php
----> Excluding wp-content/mu-plugins/sqlite-database-integration/wp-includes/sqlite/class-wp-sqlite-translator.php
----> Excluding wp-content/mu-plugins/sqlite-database-integration/wp-includes/sqlite/db.php
----> Excluding wp-content/mu-plugins/sqlite-database-integration/wp-includes/sqlite/install-functions.php
Contributor
Author
|
Thanks, Antonio! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
node_modulesand.gitpaths from site exportTesting Instructions
npm start..gitandnode_moduleswith some random files in them./wp-content/plugins,/wp-content/themes, etc. ....gitornode_modulesdirectories present.Pre-merge Checklist