Skip to content

CLI initial release - #1314

Merged
fredrikekelund merged 3 commits into
trunkfrom
f26d/cli-initial-release
May 2, 2025
Merged

CLI initial release#1314
fredrikekelund merged 3 commits into
trunkfrom
f26d/cli-initial-release

Conversation

@fredrikekelund

@fredrikekelund fredrikekelund commented May 2, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

  • Enable CLI installation for all environments (see Enable CLI installation #1253 for previous changes)
  • Only run Windows installation in production to prevent %PATH pollution
  • Set the CLI version to 1.0.0
  • Remove the commander dependency (which is no longer used by the CLI)

Testing Instructions

Code review should suffice

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@fredrikekelund
fredrikekelund requested a review from a team May 2, 2025 11:20
@fredrikekelund fredrikekelund self-assigned this May 2, 2025

@sejas sejas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can see the menu item to install CLI on Macos.

Screenshot 2025-05-02 at 13 02 07

Comment thread package.json
"archiver": "^6.0.1",
"atomically": "^2.0.3",
"cli-table3": "^0.6.5",
"commander": "^13.1.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcsecsey gcsecsey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredrikekelund
fredrikekelund merged commit 6d1bb2b into trunk May 2, 2025
@fredrikekelund
fredrikekelund deleted the f26d/cli-initial-release branch May 2, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants