Studio: Adjust margin on Advanced Settings - #1330
Merged
Merged
Conversation
katinthehatsite
marked this pull request as draft
May 6, 2025 11:52
katinthehatsite
marked this pull request as ready for review
May 6, 2025 11:57
ivan-ottinger
approved these changes
May 6, 2025
ivan-ottinger
left a comment
ivan-ottinger
left a comment
Contributor
There was a problem hiding this comment.
The change itself looks good: the space above and below the Advanced settings is balanced now.
Let's see if something more needs to be changed from the design perspective.
gcsecsey
approved these changes
May 6, 2025
gcsecsey
left a comment
gcsecsey
left a comment
Member
There was a problem hiding this comment.
Changes LGTM, and the toggle looks great both open and closed now.
| open | closed |
|---|---|
 |
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
STU-340
Proposed Changes
This PR adjusts margin for
Advanced settingsso that the distance looks visually the same below and above that field.Testing Instructions
npm startAdd sitebutton in the sidebarAdvanced Settingslooks the sameBefore
After
Pre-merge Checklist