Skip to content

Onboarding: Update tooltip position to left to unwanted overlay and screen shaking - #1337

Merged
gavande1 merged 2 commits into
trunkfrom
stu-454-hovering-over-wordpress-version-i-icon-creates-unwanted
May 7, 2025
Merged

Onboarding: Update tooltip position to left to unwanted overlay and screen shaking #1337
gavande1 merged 2 commits into
trunkfrom
stu-454-hovering-over-wordpress-version-i-icon-creates-unwanted

Conversation

@gavande1

@gavande1 gavande1 commented May 7, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

  • Update tooltip rendering position to avoid unwanted overlay and screen shaking

Testing Instructions

  • Check out this PR.
  • Apply temp change to see the onboarding screen.
diff --git a/src/components/app.tsx b/src/components/app.tsx
index c06b9cb..3224a7d 100644
--- a/src/components/app.tsx
+++ b/src/components/app.tsx
@@ -20,7 +20,7 @@ import { WhatsNewModal, useWhatsNew } from 'src/modules/whats-new';
 
 export default function App() {
        useLocalizationSupport();
-       const { needsOnboarding } = useOnboarding();
+       const { needsOnboarding } = { needsOnboarding: true }; //useOnboarding();
        const { isSidebarVisible, toggleSidebar } = useSidebarVisibility();
        const { showWhatsNew, closeWhatsNew } = useWhatsNew();
  • Start the Studio by running npm start
  • Click on Advanced settings
  • Select a WordPress version number other than latest.
  • The tooltip will be displayed.
  • Hover the cursor on the info icon.
  • Make sure the screen doesn't shake or create any additional overlay.

CleanShot 2025-05-07 at 12 35 18@2x

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@gavande1
gavande1 marked this pull request as ready for review May 7, 2025 07:09
@gavande1 gavande1 self-assigned this May 7, 2025
@gavande1
gavande1 requested a review from a team May 7, 2025 07:10
Comment thread src/components/wp-version-selector/index.tsx Outdated
@gavande1
gavande1 requested a review from katinthehatsite May 7, 2025 07:43

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR solves the issue for me 👍

Personally, I would move the icon close to WordPress versions but it is not at the matter of this PR so I am approving

@gavande1
gavande1 merged commit 9df98c0 into trunk May 7, 2025
@gavande1
gavande1 deleted the stu-454-hovering-over-wordpress-version-i-icon-creates-unwanted branch May 7, 2025 08:48
@wojtekn

wojtekn commented May 7, 2025

Copy link
Copy Markdown
Contributor

I've added #1338 for improving the icon itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants