Skip to content

Studio: Ensure the scrollbar works correctly on onboarding screen - #1339

Merged
katinthehatsite merged 1 commit into
trunkfrom
fix/scrollbar-not-working-on-onboarding
May 7, 2025
Merged

Studio: Ensure the scrollbar works correctly on onboarding screen#1339
katinthehatsite merged 1 commit into
trunkfrom
fix/scrollbar-not-working-on-onboarding

Conversation

@katinthehatsite

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

This PR ensures that the scrollbar works correctly on the onboarding screen: when you are on a scrollbar, it should scroll:

Screen.Recording.2025-05-07.at.11.14.49.AM.mov

Testing Instructions

  • Pull the changes from this branch
  • Start the app with npm start
  • Delete all Studio sites to see the onboarding screen or alternatively, apply this diff:
index c06b9cb..3224a7d 100644
--- a/src/components/app.tsx
+++ b/src/components/app.tsx
@@ -20,7 +20,7 @@ import { WhatsNewModal, useWhatsNew } from 'src/modules/whats-new';
 
 export default function App() {
        useLocalizationSupport();
-       const { needsOnboarding } = useOnboarding();
+       const { needsOnboarding } = { needsOnboarding: true }; //useOnboarding();
        const { isSidebarVisible, toggleSidebar } = useSidebarVisibility();
        const { showWhatsNew, closeWhatsNew } = useWhatsNew();
  • Once on the onboarding screen, confirm that you can use the scrollbar as expected

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@katinthehatsite katinthehatsite self-assigned this May 7, 2025

@gavande1 gavande1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are working as expected. Looks good to me! 👍

@katinthehatsite

katinthehatsite commented May 7, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for review @gavande1 ❤️

One concern that I have is that this change makes the right side of the app not draggable on the onboarding screen which might not be obvious to the user (although they are usually exposed to this screen just briefly). That said, it is the simplest solution in my opinion. I spent some time dancing around the scrollbar but I could not find something that was straightforward to keep the scrollbar working and keep the app draggable from the right side. I tried to keep the top and bottom scrollable but it was making the app look strange with the scrollbar being cut off.

Before I go down more rabbit holes with this, @wojtekn are we okay with this tradeoff? Or do you think we should explore the solution further? Thank you

@wojtekn wojtekn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be okay.

@katinthehatsite
katinthehatsite merged commit 5006274 into trunk May 7, 2025
@katinthehatsite
katinthehatsite deleted the fix/scrollbar-not-working-on-onboarding branch May 7, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants