Update Customize buttons to make them always active - #1344
Merged
Conversation
katinthehatsite
approved these changes
May 8, 2025
katinthehatsite
left a comment
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
The functionality works as expected for me and the buttons now start a site.
I noticed one small thing is that if you start and stop the site quickly, the buttons look like they somewhat glitch and go from enabled to disabled to enabled too fast. It seems like the loading state might be too short and gives this effect (see on the video below when I am clicking the second time):
Screen.Recording.2025-05-08.at.9.37.25.AM.mov
I do not think it is a common user behaviour though so I am approving the changes 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Testing Instructions
Pre-merge Checklist