Change default PHP version to 8.3 and update tests - #1352
Merged
Conversation
bcotrim
approved these changes
May 8, 2025
bcotrim
left a comment
bcotrim
left a comment
Contributor
There was a problem hiding this comment.
Works as described and all tests pass
LGTM 👍
One minor comment: have you considered using the DEFAULT_PHP_VERSION in the tests? I don't see any downsides and it avoids us needing to change all the tests in the future.
Contributor
Author
Not a strong opinion, but it seems to me that it is clearer if the test uses explicit data instead of constant/variable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Testing Instructions
Pre-merge Checklist