Skip to content

Onboarding: Update WordPress Version Tooltip Icon and Position - #1354

Merged
gavande1 merged 3 commits into
trunkfrom
stu-458-wordpress-versions-icon-is-not-readable-well
May 8, 2025
Merged

Onboarding: Update WordPress Version Tooltip Icon and Position #1354
gavande1 merged 3 commits into
trunkfrom
stu-458-wordpress-versions-icon-is-not-readable-well

Conversation

@gavande1

@gavande1 gavande1 commented May 8, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

  • Replace warning sign icon with info icon.
  • Reduce the gap between the title and the icon.

Testing Instructions

  • Check out this PR.
  • Apply temp change to see the onboarding screen.
diff --git a/src/components/app.tsx b/src/components/app.tsx
index c06b9cb..3224a7d 100644
--- a/src/components/app.tsx
+++ b/src/components/app.tsx
@@ -20,7 +20,7 @@ import { WhatsNewModal, useWhatsNew } from 'src/modules/whats-new';
 
 export default function App() {
        useLocalizationSupport();
-       const { needsOnboarding } = useOnboarding();
+       const { needsOnboarding } = { needsOnboarding: true }; //useOnboarding();
        const { isSidebarVisible, toggleSidebar } = useSidebarVisibility();
        const { showWhatsNew, closeWhatsNew } = useWhatsNew();
  • Start the Studio by running npm start
  • Click on Advanced settings
  • Select a WordPress version number other than latest.
  • The tooltip (i) will be displayed.
  • Check that the icon is positioned close to the title.
  • The updated icon is readable.
  • Also, check the tooltip position on the add site and edit site form.
Before After
CleanShot 2025-05-07 at 12 35 18@2x CleanShot 2025-05-08 at 14 23 32@2x

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@gavande1 gavande1 changed the title Onboarding: Reduce gap between title and icon May 8, 2025
@gavande1
gavande1 requested a review from a team May 8, 2025 08:56

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better, thanks for making these changes:

Screenshot 2025-05-08 at 11 02 25 AM

@bcotrim bcotrim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Although it was not changed or part of the scope of this PR, I think it is still somehow related:

  • Should we change the placement of the tooltip in the "Add site" workflow to match the one on the onboarding?

image

@gavande1

gavande1 commented May 8, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for pointing that out. I will go ahead and update Add site tooltip as well.

@gavande1
gavande1 force-pushed the stu-458-wordpress-versions-icon-is-not-readable-well branch from 6681ae8 to 8b41e2c Compare May 8, 2025 12:24
@gavande1
gavande1 requested a review from bcotrim May 8, 2025 12:25

@bcotrim bcotrim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for making the adjustment 👍

@gavande1
gavande1 merged commit 142e59d into trunk May 8, 2025
@gavande1
gavande1 deleted the stu-458-wordpress-versions-icon-is-not-readable-well branch May 8, 2025 14:04
@gavande1 gavande1 added the Bug label May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants