Patch php-wasm/universal to fix QUERY_STRING - #1356
Merged
sejas merged 3 commits intoMay 8, 2025
Merged
Conversation
sejas
commented
May 8, 2025
Contributor
|
@sejas I reproduced the error using 1.5.1-beta1 and confirmed that this PR fixes it. Thanks for preparing the patch! |
sejas
commented
May 8, 2025
Comment on lines
+22
to
+38
| - if (this[__private__dont__use].ccall( | ||
| - "wasm_set_request_uri", | ||
| - null, | ||
| - [STRING], | ||
| - [t] | ||
| - ), t.includes("?")) { | ||
| - const e = t.substring(t.indexOf("?") + 1); | ||
| + this[__private__dont__use].ccall( | ||
| + "wasm_set_request_uri", | ||
| + null, | ||
| + [STRING], | ||
| + [t] | ||
| + ); | ||
| + let e = ''; | ||
| + if (t.includes("?")) { | ||
| + e = t.substring(t.indexOf("?") + 1); | ||
| + } |
Member
Author
There was a problem hiding this comment.
This code is not actually executed; it's the non-minimized version of the patch. I modified it just for reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Testing Instructions
npm startPre-merge Checklist