Ignore .git & node_modules in preview archive

[grgar]

Export ignores .git and node_modules:

studio/src/lib/import-export/export/exporters/default-exporter.ts

Lines 233 to 234 in 0c0f64d

	const isNodeModulesDirectory = relativePath.includes( 'node_modules' );
	const isGitDirectory = relativePath.includes( '.git' );

Preview did not, causing a failure to create the archive for me due to the following error:

could not open for reading: .git/fsmonitor--daemon.ipc

Proposed Changes

• Ignore .git and node_modules in wp-content.

Testing Instructions

1. git init inside wp-content
2. git config core.fsmonitor true if not already set globally and trigger the ipc file creation (e.g. run git status)
3. Create a preview

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[sejas]

@grgar, Thank you for creating this PR. I tested it and confirm that it works as expected, excluding the .git and node_modules folders. This will speed up the process of uploading the zip and also fix your issue.

I tried to push the changes to format the code, but I don't have write access. Could you either apply the changes to your branch or grant edit access to maintainers?

[grgar]

Thanks @sejas, apologies I've applied your suggestion thank you.

I also don't appear to have that option to grant edit access unfortunately

edit: it appears to be because I put forks in a separate organisation to keep my account tidy and https://github.com/orgs/community/discussions/5634 — sorry I didn't realise the issue that causes

[sejas]

I tested this PR, and it works correctly. I confirm that preview sites work as before, with the exception that archive files will exclude development folders ('.git' and 'node_modules').

@wojtekn , I think this is good to merge.

[sejas]

I see the unit tests are failing. @grgar, could you apply this diff to fix the tests?
If you prefer, you can invite me to your forked repo. Thank you!

diff --git a/cli/lib/tests/archive.test.ts b/cli/lib/tests/archive.test.ts
index 15f2c1db..bb59ac32 100644
--- a/cli/lib/tests/archive.test.ts
+++ b/cli/lib/tests/archive.test.ts
@@ -51,7 +51,11 @@ describe( 'Archive Module', () => {
 			expect( archiver ).toHaveBeenCalledWith( 'zip', { zlib: { level: 9 } } );
 			expect( mockArchiver.pipe ).toHaveBeenCalledWith( mockWriteStream );
 			expect( path.join ).toHaveBeenCalledWith( mockSiteFolder, 'wp-content' );
-			expect( mockArchiver.directory ).toHaveBeenCalledWith( mockWpContentPath, 'wp-content' );
+			expect( mockArchiver.directory ).toHaveBeenCalledWith(
+				mockWpContentPath,
+				'wp-content',
+				expect.any( Function )
+			);
 			expect( path.join ).toHaveBeenCalledWith( mockSiteFolder, 'wp-config.php' );
 			expect( fs.existsSync ).toHaveBeenCalledWith( mockWpConfigPath );
 			expect( mockArchiver.file ).not.toHaveBeenCalled();

[grgar]

Thanks @sejas I've applied the patch and invited you to the fork if you want to push anything, sorry again about that issue I won't use an org in the future until GitHub fix the issue!

[wojtekn]

Thanks @grgar ! I triggered builds for those changes.

[sejas]

@grgar , thanks for applying the changes 🫶 .

@wojtekn, thanks for triggering the builds. All tests have passed ✅ .