Translate what's new links - #1368
Conversation
gcsecsey
left a comment
gcsecsey
left a comment
There was a problem hiding this comment.
Changes LGTM and it works well for me too! I managed to open the Spanish blog post by following the testing steps. 👍
| 'Easily identify your local Studio sites with custom domain names. Personalize and organize your workflow!' | ||
| ), | ||
| learnMoreUrl: 'https://wordpress.com/blog/2025/03/31/studio-custom-domains-https/', | ||
| learnMoreUrl: translateLink( |
There was a problem hiding this comment.
What if we followed the same approach as we took for docs, so we would have getBlogLink that checks if there is an internationalized URL and returns it?
There was a problem hiding this comment.
I thought about that. I'll create a second PR for that.
There was a problem hiding this comment.
Wouldn't it be mainly about renaming src/lib/translate-link.ts and its methods?
There was a problem hiding this comment.
I miss-read your first comment. I thought you were suggesting to unify both functions, because I was thinking on that from the moment I created this PR. I also like having all the links indexed.
Check out this PR, and let me know what you think. It has the best from both worlds: #1375
4 participants
Related issues
Proposed Changes
Testing Instructions
npm startwhats-new-support-multiple-languages.mp4
Pre-merge Checklist