Use same state for preview site usage and create preview site button

[gcsecsey]

Related issues

• Fixes STU-484 Can't add more than 3 preview sites

Proposed Changes

While working on 182791-ghe-Automattic/wpcom I ran into the issue of not being able to add more preview sites. The Usage tab showed 9 sites but I couldn't press the Create preview site button to add a new one.

• Update the snapshot count in create-preview-button.tsx to use the same state as user-settings.tsx for the number of active sites

Testing Instructions

• Follow the test instructions on 182791-ghe-Automattic/wpcom
• Make sure that when the usage tab shows <10 active sites, the Create preview site button is enabled
• Check that when you have 10 active preview sites, the Create preview site button is disabled

9 sites	10 sites

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[fredrikekelund]

Good catch 👍 I haven't tested it, but I can verify that this is the correct behavior.

[gcsecsey]

We double-checked this with @wojtekn just now, and it seems that the root cause of the issue was the state mismatch here, the backend was counting active sites correctly. I went ahead and closed 182791-ghe-Automattic/wpcom now.

[ivan-ottinger]

Nice find! The proposed change looks good and works as expected. 👌🏼

I was able to reproduce the issue with only one active preview site and the PR fixes it:

Before	After