Skip to content

Settings: Fix click events when no sites exist - #1390

Merged
epeicher merged 2 commits into
trunkfrom
stu-498-unable-to-click-tabs-in-settings-modal-when-no-site-exists
May 14, 2025
Merged

Settings: Fix click events when no sites exist#1390
epeicher merged 2 commits into
trunkfrom
stu-498-unable-to-click-tabs-in-settings-modal-when-no-site-exists

Conversation

@epeicher

@epeicher epeicher commented May 14, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

  • Add app-no-drag-region class to the Modal so pointer events are listened.
  • The div that was causing the pointer events to be ignored is this one
CleanShot.2025-05-14.at.12.46.23.mp4

Testing Instructions

  • Apply this branch and run npm start
  • Delete all sites
  • Open the settings or press Cmd+,
  • Check that you can click on the Preferences and Usage tabs

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@epeicher
epeicher requested a review from a team May 14, 2025 10:44
@wojtekn

wojtekn commented May 14, 2025

Copy link
Copy Markdown
Contributor

@epeicher it fixes the issue, but now half of the Settings dialog is draggable and half is not. Should we make the entire dialog non-draggable, so only the blue part is draggable?

@nightnei

nightnei commented May 14, 2025

Copy link
Copy Markdown
Contributor

Works well, but totally agree with @wojtekn about making the whole dialog non-graggable. Also I think that it's more neat to go this way, to handle whole dialog instead of just part of it.

@epeicher

Copy link
Copy Markdown
Contributor Author

Thanks @wojtekn and @nightnei for the review. I didn't realise I was adding it to a piece of the modal, good catch! I have updated it as part of 0f8b5b7

@nightnei nightnei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected for me 👍

@gcsecsey gcsecsey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and it works well!

@epeicher
epeicher merged commit f444709 into trunk May 14, 2025
@epeicher
epeicher deleted the stu-498-unable-to-click-tabs-in-settings-modal-when-no-site-exists branch May 14, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants