Settings: Fix click events when no sites exist - #1390
Merged
epeicher merged 2 commits intoMay 14, 2025
Merged
Conversation
Contributor
|
@epeicher it fixes the issue, but now half of the Settings dialog is draggable and half is not. Should we make the entire dialog non-draggable, so only the blue part is draggable? |
Contributor
|
Works well, but totally agree with @wojtekn about making the whole dialog non-graggable. Also I think that it's more neat to go this way, to handle whole dialog instead of just part of it. |
Contributor
Author
katinthehatsite
approved these changes
May 14, 2025
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
Works as expected for me 👍
wojtekn
approved these changes
May 14, 2025
epeicher
deleted the
stu-498-unable-to-click-tabs-in-settings-modal-when-no-site-exists
branch
May 14, 2025 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
app-no-drag-regionclass to the Modal so pointer events are listened.CleanShot.2025-05-14.at.12.46.23.mp4
Testing Instructions
npm startCmd+,PreferencesandUsagetabsPre-merge Checklist