Skip to content

Add a mu-plugin to enable permalinks without index.php in the URL - #143

Merged
sejas merged 1 commit into
trunkfrom
add/permalinks
May 22, 2024
Merged

Add a mu-plugin to enable permalinks without index.php in the URL#143
sejas merged 1 commit into
trunkfrom
add/permalinks

Conversation

@sejas

@sejas sejas commented May 17, 2024

Copy link
Copy Markdown
Member

Proposed Changes

  • Add a mu-plugin that enables having permalinks without the index.php in the URL.

Testing Instructions

  • Apply this PR in your local machine
  • Run nvm use && npm install && npm start
  • In an existing or new site access Settings > Permalinks: /wp-admin/options-permalink.php
  • Observe the given options does not have index.php
  • Select any permalink
  • Access the forntend page, click on the menu item Sample in the frontend.
Before After
permalinks-before permalinks-after

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@sejas sejas self-assigned this May 17, 2024
@sejas
sejas requested a review from a team May 17, 2024 14:07
@derekblank
derekblank self-requested a review May 20, 2024 04:49

@derekblank derekblank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. With the changes applied using got_url_rewrite, I observed that permalinks without index.php were enabled. 🚀

trunk add/permalinks
permalinks-before permalinks-after

@wojtekn wojtekn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks clear, works as expected.

@sejas
sejas merged commit 6bc0ce3 into trunk May 22, 2024
@sejas
sejas deleted the add/permalinks branch May 22, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants