Skip to content

Studio: Fix stop server error #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kozer merged 3 commits into from
May 22, 2024
Merged

Studio: Fix stop server error #144

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6c927a
Studio: Fix stop server error
kozer May 17, 2024
a44dbbc
Update: Capture error in sentry
kozer May 20, 2024
05e2366
Update: move handling inside killProcess
kozer May 21, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lib/site-server-process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { app, utilityProcess, UtilityProcess } from 'electron';
import { PHPRunOptions } from '@php-wasm/universal';
import * as Sentry from '@sentry/electron/renderer';
import { WPNowOptions } from '../../vendor/wp-now/src/config';

// This allows TypeScript to pick up the magic constants that's auto-generated by Forge's Webpack
Expand Down Expand Up @@ -135,7 +136,7 @@ export default class SiteServerProcess {
throw Error( 'Server process is not running' );
}

return new Promise( ( resolve, reject ) => {
return new Promise< void >( ( resolve, reject ) => {
process.once( 'exit', ( code ) => {
if ( code !== 0 ) {
reject( new Error( `Site server process exited with code ${ code } upon stopping` ) );
Expand All @@ -144,6 +145,8 @@ export default class SiteServerProcess {
resolve();
} );
process.kill();
} ).catch( ( error ) => {
Sentry.captureException( error );
} );
}
}