Skip to content

User Settings: "Command Prompt" shows as "Terminal" in dropdown options on Windows - #1441

Merged
gavande1 merged 2 commits into
trunkfrom
stu-530-user-settings-command-prompt-shows-as-terminal-in-dropdown
May 28, 2025
Merged

User Settings: "Command Prompt" shows as "Terminal" in dropdown options on Windows#1441
gavande1 merged 2 commits into
trunkfrom
stu-530-user-settings-command-prompt-shows-as-terminal-in-dropdown

Conversation

@gavande1

@gavande1 gavande1 commented May 27, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

Currently, on Windows, the "Command Prompt" option shows as "Terminal" in the dropdown options. This PR refactors a way to get a terminal name in the content-tab-overview and terminal-picker components.

Before on Windows After on Windows
CleanShot 2025-05-27 at 15 59 02@2x CleanShot 2025-05-27 at 16 42 32@2x

Testing Instructions

  • Check out this branch on Windows
  • Go to Preferences
  • Ensure you see "Command Prompt" instead of "Terminal".

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@gavande1
gavande1 marked this pull request as ready for review May 27, 2025 11:24
@gavande1
gavande1 requested a review from a team May 27, 2025 12:05

@bcotrim bcotrim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor! I have tested it, and it works as advertised. LGTM! :shipit:

CleanShot 2025-05-27 at 15 18 50@2x

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected!

@gavande1
gavande1 merged commit 4da4473 into trunk May 28, 2025
@gavande1
gavande1 deleted the stu-530-user-settings-command-prompt-shows-as-terminal-in-dropdown branch May 28, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants