Skip to content

Disable topbar log in button when offline - #1494

Merged
sejas merged 2 commits into
trunkfrom
update/stu-582-studio-disable-wordpresscom-log-in-when-logout
Jun 23, 2025
Merged

Disable topbar log in button when offline#1494
sejas merged 2 commits into
trunkfrom
update/stu-582-studio-disable-wordpresscom-log-in-when-logout

Conversation

@sejas

@sejas sejas commented Jun 20, 2025

Copy link
Copy Markdown
Member

Related issues

Proposed Changes

  • Disable main login button when offline and add tooltip.

Testing Instructions

  • Run npm start
  • Make sure you are logged out
  • Disable your internet connection
  • Observe the login button has a lower opacity
  • Move the mouse hover
  • Observe the tooltip that says "You're currently offline."
login-disabled.mp4

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@sejas sejas self-assigned this Jun 20, 2025
@sejas
sejas requested a review from a team June 20, 2025 17:08

@bcotrim bcotrim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and works as described.
Tested on different languages, including RTL.
👍

@wojtekn wojtekn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected. It now makes sense as we added another button to access Preferences.

@katinthehatsite

Copy link
Copy Markdown
Contributor

Should this button then be cleaned up under the account tab:

Screenshot 2025-06-23 at 10 38 56 AM

It does come up as disabled but it seems that the same setting is now present in two different places.

@wojtekn

wojtekn commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

@katinthehatsite I think it should staIt does come up as disabled but it seems that the same setting is now present in two different places.

This duplication doesn't look harmful as in Settings the authenticated state changes to unauthenticated state when users logs out. In think we can leave it as is for now, and we could potentially simplify it in the future e.g. by making Log out action closing the Preferences dialog.

@sejas
sejas merged commit eaa8185 into trunk Jun 23, 2025
12 checks passed
@sejas
sejas deleted the update/stu-582-studio-disable-wordpresscom-log-in-when-logout branch June 23, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants