Disable topbar log in button when offline - #1494
Merged
sejas merged 2 commits intoJun 23, 2025
Merged
Conversation
bcotrim
approved these changes
Jun 20, 2025
bcotrim
left a comment
Contributor
There was a problem hiding this comment.
Code LGTM and works as described.
Tested on different languages, including RTL.
👍
wojtekn
approved these changes
Jun 23, 2025
wojtekn
left a comment
Contributor
There was a problem hiding this comment.
It works as expected. It now makes sense as we added another button to access Preferences.
Contributor
Contributor
This duplication doesn't look harmful as in Settings the authenticated state changes to unauthenticated state when users logs out. In think we can leave it as is for now, and we could potentially simplify it in the future e.g. by making Log out action closing the Preferences dialog. |
sejas
deleted the
update/stu-582-studio-disable-wordpresscom-log-in-when-logout
branch
June 23, 2025 10:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related issues
Proposed Changes
Testing Instructions
npm startlogin-disabled.mp4
Pre-merge Checklist