Skip to content

Reset translations after changing any language - #1534

Merged
sejas merged 1 commit into
trunkfrom
fix/stu-602-studio-sync-fix-selective-sync-translations
Jul 4, 2025
Merged

Reset translations after changing any language#1534
sejas merged 1 commit into
trunkfrom
fix/stu-602-studio-sync-fix-selective-sync-translations

Conversation

@sejas

@sejas sejas commented Jul 3, 2025

Copy link
Copy Markdown
Member

Related issues

Proposed Changes

  • Fix mixed translations and use English as a fallback. There was a bug where, when a translation was missing in the selected language, switching from another language would display the previous language's string instead of English.

Testing Instructions

  • Run npm start
  • Set your language to Ukranian
  • Open the push dialog
  • Observe everything is translated to Ukrainian
  • Change the language to Spanish or Hebrew
  • Observe most is translated to those languages, but some parts like the title and description are in English because those translations doesn't exist yet.
default-translations-should-use-english.mp4

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@sejas sejas self-assigned this Jul 3, 2025
@sejas
sejas requested review from a team and katinthehatsite July 3, 2025 17:10

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Antonio! I have tested it, and it works as described. LGTM! :shipit:

Ukranian Español
CleanShot 2025-07-03 at 19 24 24@2x CleanShot 2025-07-03 at 19 24 39@2x
@sejas
sejas merged commit 63f60b5 into trunk Jul 4, 2025
13 of 14 checks passed
@sejas
sejas deleted the fix/stu-602-studio-sync-fix-selective-sync-translations branch July 4, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants