Fix: Ensure plugin, theme, and WordPress updates succeed - #156
Conversation
The fix available is now included in the main @php-wasm/node/index.cjs file, so this patch is no longer necessary.
This reverts commit 767b43c.
sejas
left a comment
There was a problem hiding this comment.
@SiobhyB , First of all ... You are AWESOME!
Congrats for working on this bug until the very end and creating a PR on https://github.com/emscripten-core/emscripten 👏
I think it's good idea to ship this change until the fix is released in the dependency libraries.
I tested updating a plugin and whole WordPress and both worked as expected. Yay!
Update plugin
update-plugin.mp4
Update WordPress
update-wordpress.mp4
|
@sejas, thanks so much for all your help and support with this one, too! 🙌 |
|
@wojtekn, is there still time to get this one into the |
|
@SiobhyB yes! Thanks for the fix, works great now. I tested it with my local site that uses MySQL and it updated Jetpack from 13.4.2 to 13.4.3 successfully. I also tested upgrading the whole WordPress core from 6.5.2 to 6.5.3 and from 6.4.3 to 6.5.3 and both cases worked fine, too. |
Fixes: 6891-gh-Automattic/dotcom-forge, #100
Relates to: WordPress/playground-tools#178
Proposed Changes
A fix to prevent plugins, themes, and WordPress updates from failing was recently merged into the Emscripten repository in emscripten-core/emscripten#21964. The next Emscripten release is due in around two weeks time, at which point a new release for PHP-WASM will be needed. As it may take some time for these updates to happen, and due to the high priority of this bug, I propose a temporary patch so that the fix gets to Studio users a bit quicker.
In this PR, I've updated the existing PHP-WASM patch to include the fix for update errors.
Testing Instructions
Update an outdated plugin
Recording:
updates.mov
Update an outdated version of WordPress
Recording:
wordpress-update.mov
General smoke testing
Ensure no regressions by testing general functionality related to installations. It should still be possible to install plugins and themes as before.
Pre-merge Checklist