Skip to content

Studio: Add translation to demo site expiration date #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katinthehatsite merged 8 commits into from
Apr 26, 2024
Merged

Studio: Add translation to demo site expiration date #16

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4a242aa
Add basic logic for translation
Apr 23, 2024
03e116d
Add back the comment that was accidentally removed
Apr 23, 2024
4a76289
Add singluar values for translation
Apr 23, 2024
959b29c
Refactor from using replace to using reduce
Apr 23, 2024
d250930
Remove unncessary comment
Apr 23, 2024
3ffd0b9
Move constants into strings
Apr 24, 2024
cbedb01
Remove double import
Apr 24, 2024
115f9ec
Pass locale into formatDistance
Apr 25, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion src/hooks/use-expiration-date.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { _n, sprintf } from '@wordpress/i18n';
import { useI18n } from '@wordpress/react-i18n';
import { intervalToDuration, formatDuration, addDays, Duration, addHours } from 'date-fns';

Expand Down Expand Up @@ -36,8 +37,29 @@ export function useExpirationDate( snapshotDate: number ) {
// we show the minutes left.
end: addHours( endDate, 1 ),
} ),
{ format, delimiter: ', ' }
{
format,
delimiter: ', ',
locale: {
formatDistance: ( token, count ) => {
let stringToFormat = '';
switch ( token ) {

@wojtekn wojtekn Apr 26, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really readable and easy to understand!
case 'xDays':
stringToFormat = _n( '%d day', '%d days', count );
break;
case 'xHours':
stringToFormat = _n( '%d hour', '%d hours', count );
break;
case 'xMinutes':
stringToFormat = _n( '%d minute', '%d minutes', count );
break;
}
return sprintf( stringToFormat, count );
},
},
}
);

return {
isExpired,
countDown: isExpired ? __( 'Expired' ) : countDown,
Expand Down