Skip to content

Set the selective sync checkboxes to be unchecked as initial state - #1626

Merged
sejas merged 4 commits into
trunkfrom
update/stu-655-studio-set-the-selective-sync-checkboxes-to-be-unchecked
Aug 1, 2025
Merged

Set the selective sync checkboxes to be unchecked as initial state#1626
sejas merged 4 commits into
trunkfrom
update/stu-655-studio-set-the-selective-sync-checkboxes-to-be-unchecked

Conversation

@sejas

@sejas sejas commented Jul 31, 2025

Copy link
Copy Markdown
Member

Related issues

Proposed Changes

  • Let's set the initial state for the Selective Sync Dialog to unchecked.
  • Update tests

Testing Instructions

  • Run npm start
  • Go to Sync
  • Connect a site
  • Click Pull or Push
  • Confirm the dialog has unchecked the checkboxes by default
  • Play changing the dropdown to specific files and folders
  • Confirm the state is respected.
Before After
Screenshot 2025-07-31 at 13 30 17 Screenshot 2025-07-31 at 10 23 27

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@sejas sejas self-assigned this Jul 31, 2025
@sejas sejas changed the title Update/stu 655 studio set the selective sync checkboxes to be unchecked Jul 31, 2025
@sejas
sejas requested a review from a team July 31, 2025 12:30

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Antonio for the changes! I can confirm that the dialog has unchecked the checkboxes by default as expected.

However, there is one scenario that I would like to double check. If I select Specific files and folders, select some folders, and then I change my mind and select All files and folders, I would expect the Files and folders checkbox to be selected, but it is unchecked. Please see video below

CleanShot.2025-08-01.at.10.39.39.mp4

Do you think in that scenario theFiles and folders checkbox should be checked? 🤔

sejas commented Aug 1, 2025

Copy link
Copy Markdown
Member Author

Thank you for reviewing the PR and highlighting that behavior. I implemented the logic to inherit the checked value, but I think your suggestion feels more natural. If the user has partially selected a child element, we can automatically check the Files and Folders parent node. 👌. I'll update it now.

sejas commented Aug 1, 2025

Copy link
Copy Markdown
Member Author

Done! 1e4bef8

partially-selected-tree.mp4
@sejas
sejas requested a review from epeicher August 1, 2025 09:38

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Antonio for addressing the suggestion! I have tested it, and it works as advertised, I can see the initial values deselected, and when selecting some and then changing to All files and folders, the checkbox is marked. I have also tried with Pull and Push and they both work as expected. LGTM! :shipit:

CleanShot.2025-08-01.at.11.45.25.mp4

@gcsecsey gcsecsey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM and this works well for me too. 👍

CleanShot.2025-08-01.at.10.55.11.mp4

@nightnei nightnei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected and the code LGTM 👍

@sejas
sejas merged commit 36368cd into trunk Aug 1, 2025
12 checks passed
@sejas
sejas deleted the update/stu-655-studio-set-the-selective-sync-checkboxes-to-be-unchecked branch August 1, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants