Set the selective sync checkboxes to be unchecked as initial state - #1626
Conversation
epeicher
left a comment
There was a problem hiding this comment.
Thanks Antonio for the changes! I can confirm that the dialog has unchecked the checkboxes by default as expected.
However, there is one scenario that I would like to double check. If I select Specific files and folders, select some folders, and then I change my mind and select All files and folders, I would expect the Files and folders checkbox to be selected, but it is unchecked. Please see video below
CleanShot.2025-08-01.at.10.39.39.mp4
Do you think in that scenario theFiles and folders checkbox should be checked? 🤔
|
Thank you for reviewing the PR and highlighting that behavior. I implemented the logic to inherit the checked value, but I think your suggestion feels more natural. If the user has partially selected a child element, we can automatically check the Files and Folders parent node. 👌. I'll update it now. |
|
Done! 1e4bef8 partially-selected-tree.mp4 |
epeicher
left a comment
There was a problem hiding this comment.
Thanks Antonio for addressing the suggestion! I have tested it, and it works as advertised, I can see the initial values deselected, and when selecting some and then changing to All files and folders, the checkbox is marked. I have also tried with Pull and Push and they both work as expected. LGTM! ![]()
CleanShot.2025-08-01.at.11.45.25.mp4
gcsecsey
left a comment
There was a problem hiding this comment.
Changes LGTM and this works well for me too. 👍
CleanShot.2025-08-01.at.10.55.11.mp4
nightnei
left a comment
There was a problem hiding this comment.
Works as expected and the code LGTM 👍
Related issues
Proposed Changes
Testing Instructions
npm startPre-merge Checklist