Skip to content

Allow site deletion in offline mode by skipping Preview sites cleanup - #1638

Merged
ivan-ottinger merged 3 commits into
trunkfrom
remove/offline-check-from-site-deletion-when-preview-sites-are-involved
Aug 6, 2025
Merged

Allow site deletion in offline mode by skipping Preview sites cleanup#1638
ivan-ottinger merged 3 commits into
trunkfrom
remove/offline-check-from-site-deletion-when-preview-sites-are-involved

Conversation

@ivan-ottinger

@ivan-ottinger ivan-ottinger commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

  • allow local Studio site deletion when offline while skipping preview site cleanup

Testing Instructions

  1. Check out the PR branch and build the app with npm start.
  2. Create a preview site for one of your local Studio site.
  3. Go offline (e.g. by disabling wifi).
  4. Try to delete the local Studio site with linked preview site.
  5. The local site should get deleted without triggering preview site deletion (i.e. there should be no "Deleting preview site failed" error displayed in the UI and when you navigate to the Usage tab in the app Settings, the preview site should still be counted to the total limit)

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@ivan-ottinger ivan-ottinger self-assigned this Aug 5, 2025
@ivan-ottinger
ivan-ottinger requested a review from a team August 5, 2025 14:16

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this Ivan! I can confirm that I am able to delete my site and I see the preview site counted to the total limit. LGTM! :shipit:

image
@ivan-ottinger
ivan-ottinger merged commit d6585e6 into trunk Aug 6, 2025
12 checks passed
@ivan-ottinger
ivan-ottinger deleted the remove/offline-check-from-site-deletion-when-preview-sites-are-involved branch August 6, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants