Ensure to delete preview sites only when the user is authenticated - #1641
Merged
ivan-ottinger merged 1 commit intoAug 6, 2025
Conversation
gcsecsey
approved these changes
Aug 6, 2025
gcsecsey
left a comment
Member
There was a problem hiding this comment.
Thanks Ivan for quickly creating a fix! This works well and the changes LGTM!
Deleting the site while logged out:
CleanShot.2025-08-06.at.11.06.05.mp4
Deleting the site while offline:
CleanShot.2025-08-06.at.11.09.38.mp4
ivan-ottinger
deleted the
add/isAuthenticated-check-for-preview-sites-deletion-during-site-deletion
branch
August 6, 2025 10:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Testing Instructions
npm start.Pre-merge Checklist