Add full sentence translations to the pull push dialog to support languages with declinations - #1648
Conversation
|
Badges are being updated in #1645 |
I think we could merge your PR first and I will then rebase mine. Going to review yours now. 🙂 |
I am a bit lost on this step. Does this need to be done on the Pressable site? Thanks 🙇 |
|
It's in WPcom Network Admin. Let me send you the link. |
katinthehatsite
left a comment
katinthehatsite
left a comment
There was a problem hiding this comment.
I did not spot any regressions and the changes worked as expected for me. I also saw all the versions of the dialog that were presented on the screenshots in the PR description 👍
| return parsed.success ? parsed.data : 'production'; | ||
| }; | ||
|
|
||
| export const getEnvironmentLabel = ( type: string ): string => { |
There was a problem hiding this comment.
I was going to mention that this also would need to be updated but I see that it is being implemented in https://github.com/Automattic/studio/pull/1645/files 👍
ivan-ottinger
left a comment
ivan-ottinger
left a comment
There was a problem hiding this comment.
Nice! Thank you for those changes, Antonio. The logic looks good and works as expected in all cases:
| Pull | Push |
|---|---|
 |
 |
 |
 |
 |
 |
 |
 |
The Production was used for non-standard environment type as expected as well. 👍🏼
I left just one suggestion / consideration for a copy change in the inline comments below.
Modify your production or staging WPcom's
environment_typeto development in network admin settings tab.
This is a time-saver when it comes to testing environment_type changes. Thanks!
| local: { | ||
| title: __( 'Pull from remote Local' ), | ||
| description: __( | ||
| "Pulling will overwrite your Studio site's selected files and database with a copy from your remote site with local environment. Unchecked items will not be changed." |
There was a problem hiding this comment.
This doesn't sound very clear.
There was a problem hiding this comment.
We'll remove the remote local environment type from Studio in https://github.com/Automattic/studio/pull/1645/files#diff-afa3cab5af25735a5b33b66f73efe079aadcbc7ded98e89c72fbb2fcb5687eda
Thanks for the feedback.
There was a problem hiding this comment.
Thanks for linking those, makes sense.
4 participants
Related issues
Proposed Changes
Production.Testing Instructions
developmentin network admin settings tab.npm startLocal, for that case I added "remote Local" to differentiate with Studio site.Pre-merge Checklist