Ensure screenshot taken on Mac has always correct size - #1676
Merged
Conversation
Contributor
Author
|
Thanks for reviewing and testing @nightnei . The bigger screenshot was the desired one - it was configured as a constant of 1040 x 1248, and the incorrect screenshot on Mac had proportions close to square. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Related issues
Proposed Changes
I propose to explicitly set the browser size to ensure the screenshot taken on a Mac always has the correct size. I was consistently getting different thumbnail sizes when connected to an external monitor (correct) and without a monitor (incorrect):
External monitor:
Macbook:
Testing Instructions
Pre-merge Checklist