Skip to content

Improve error displayed when pushing large site - #1732

Merged
sejas merged 11 commits into
trunkfrom
update/stu-737-improve-error-displayed-when-pushing-large-site
Sep 4, 2025
Merged

Improve error displayed when pushing large site#1732
sejas merged 11 commits into
trunkfrom
update/stu-737-improve-error-displayed-when-pushing-large-site

Conversation

@sejas

@sejas sejas commented Sep 2, 2025

Copy link
Copy Markdown
Member

Related issues

Proposed Changes

  • Disable the push button and display a warning notice when the user's selection exceeds our 2GB limit for push.
Screenshot 2025-09-04 at 10 08 35

Testing Instructions

  • Run npm start
  • Create a new site
  • Move a big file into a specific folder
  • Go to the Sync tab and connect a remote site
  • Click on Push
  • Select any folder
  • Observe the push is enabled
  • Select the folder containing the big file, or the file itself.
  • Observe that the push is disabled and a warning notice appears, suggesting to change your selection.
push-selection-over-size-limit.mp4

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@sejas sejas self-assigned this Sep 2, 2025
@sejas
sejas requested a review from a team September 3, 2025 15:44
@sejas

sejas commented Sep 3, 2025

Copy link
Copy Markdown
Member Author

The warning is similar to the one being added on staging sites for a different purpose. Automattic/wp-calypso#105448

Comment thread src/modules/sync/components/sync-dialog.tsx Outdated

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works well, I did not spot any weird behaviours. I left one comment with a suggestion for visual improvements.

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Antonio for improving this! I have tested it, and I can see the error message indicating the size limit working as expected, also disabling the button. LGTM! :shipit:

Over the limit Less than the limit
CleanShot 2025-09-04 at 11 23 33@2x CleanShot 2025-09-04 at 11 23 38@2x
@sejas
sejas merged commit 07d000d into trunk Sep 4, 2025
13 checks passed
@sejas
sejas deleted the update/stu-737-improve-error-displayed-when-pushing-large-site branch September 4, 2025 10:09
@wojtekn

wojtekn commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

@sejas, this is a great step to improve UX around the size limits.

How does it work for the database?

sejas commented Sep 10, 2025

Copy link
Copy Markdown
Member Author

Thanks @wojtekn 🙌.
For the database, it checks the size of the .ht.sqlite file as a rough estimate.

@wojtekn

wojtekn commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

Thanks for the clarification, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants