Add application menu on Windows - #174
Conversation
|
@fluiddot thanks, menu still works correctly on macOS and works fine on Windows. It's a significant gain as now Windows users can:
I noticed some minor glitches:
However, we can tackle those under separate issues/PRs. |
Good catch @wojtekn. I'll tweak the menu items based on the platform, in the case of Windows some of them won't be included. |
|
I've updated the app menu item for Windows in bc373f1. The following items/menus have been removed:
|
wojtekn
left a comment
There was a problem hiding this comment.
Window: Seems only relevant for macOS:
Actually, Window -> Minimize worked as expected on Windows. The Window -> Zoom did nothing.
Yep, I also noticed that when testing. We could keep the Windows menu with only the Minimize item, but I found it redundant as we have the minimize button in the title bar. |

Related to 7084-gh-Automattic/dotcom-forge.
Proposed Changes
setupMenufunction to a new functiongetAppMenu. This function will be used when setting up the application menu on macOS and when displaying the app menu as a context menu on Windows.popupMenuto display the app menu as a context menu.WindowsTitlebarcomponent. This button will trigger the context menu.Testing Instructions
Windows
macOS
Pre-merge Checklist