Improve RTL layouts - #18
Merged
Merged
Conversation
Contributor
|
@derekblank, as we are fixing support for RTL, should we fix the missing left black border, which seems to be the biggest difference between LTR and RTL? |
Contributor
Contributor
Author
wojtekn
approved these changes
May 2, 2024
wojtekn
left a comment
Contributor
There was a problem hiding this comment.
Thanks @derekblank , it looks great for RTL language now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Resolves Automattic/dotcom-forge#6375
Proposed Changes
Improves support for RTL layouts by updating compatible padding, margin, and spacing values when RTL languages are used.
Testing Instructions
Change 1: Mirror the action button icon
Change 2: Add padding to Content tab
Change 3: Fix label spacing and alignment on Settings tab
Change 4: Updates ScreenshotDemoSite background
Known issues not addressed in this PR
Pre-merge Checklist