Skip to content

Improve RTL layouts - #18

Merged
derekblank merged 14 commits into
trunkfrom
feat/rtl-layouts
May 2, 2024
Merged

Improve RTL layouts#18
derekblank merged 14 commits into
trunkfrom
feat/rtl-layouts

Conversation

@derekblank

@derekblank derekblank commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Resolves Automattic/dotcom-forge#6375

Proposed Changes

Improves support for RTL layouts by updating compatible padding, margin, and spacing values when RTL languages are used.

Testing Instructions

  1. Change system locale to an RTL language, like Hebrew. (Steps to change system locale on macOS, for example.)
  2. Test and observe the following RTL layout-based issues are not present:

Change 1: Mirror the action button icon

Before After
צילום מסך 2024-04-19 ב-3 06 17 אח׳ צילום מסך 2024-04-19 ב-3 05 16 אח׳

Change 2: Add padding to Content tab

Before After
צילום מסך 2024-04-19 ב-3 06 12 אח׳ צילום מסך 2024-04-19 ב-3 05 26 אח׳

Change 3: Fix label spacing and alignment on Settings tab

Before After
צילום מסך 2024-04-19 ב-3 12 15 אח׳ צילום מסך 2024-05-01 ב-6 16 53 אח׳

Change 4: Updates ScreenshotDemoSite background

Before After
צילום מסך 2024-04-19 ב-3 06 23 אח׳ צילום מסך 2024-04-19 ב-3 05 58 אח׳

Known issues not addressed in this PR

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@derekblank derekblank self-assigned this Apr 24, 2024
@derekblank
derekblank requested a review from a team May 1, 2024 08:23
@derekblank
derekblank marked this pull request as ready for review May 1, 2024 08:24
@wojtekn

wojtekn commented May 2, 2024

Copy link
Copy Markdown
Contributor

@derekblank, as we are fixing support for RTL, should we fix the missing left black border, which seems to be the biggest difference between LTR and RTL?

צילום מסך 2024-05-02 ב-11 13 01

@matt-west

matt-west commented May 2, 2024

Copy link
Copy Markdown
Contributor

as we are fixing support for RTL, should we fix the missing left black border, which seems to be the biggest difference between LTR and RTL?

+1

We'd need to remove the LTR padding from the right side too. The border above the add site button should span the full-width between the content pane and the edge of the window.

Screenshot 2024-05-02 at 10 30 57
@derekblank

Copy link
Copy Markdown
Contributor Author

As we are fixing support for RTL, should we fix the missing left black border, which seems to be the biggest difference between LTR and RTL?
We'd need to remove the LTR padding from the right side too. The border above the add site button should span the full-width between the content pane and the edge of the window.

Updated for both. 👍

צילום מסך 2024-05-02 ב-9 53 22 אח׳

@wojtekn wojtekn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @derekblank , it looks great for RTL language now.

@derekblank
derekblank merged commit d038f2e into trunk May 2, 2024
@derekblank
derekblank deleted the feat/rtl-layouts branch May 2, 2024 12:43
@claude claude Bot mentioned this pull request Nov 11, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants