Skip to content

Fix What's New close button color - #1805

Merged
bcotrim merged 1 commit into
trunkfrom
fix/whats_new_close_button_color
Sep 23, 2025
Merged

Fix What's New close button color#1805
bcotrim merged 1 commit into
trunkfrom
fix/whats_new_close_button_color

Conversation

@bcotrim

@bcotrim bcotrim commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

  • Change the selector for the what's new modal close button. It was using the aria-label, which for other languages was not working.

Testing Instructions

  • Start Studio
  • Open What's New modal
  • Check the close button is white
  • Change language (RTL and others)
  • Open What's New modal
  • Check the close button is white

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@bcotrim
bcotrim requested a review from sejas September 22, 2025 17:31
@bcotrim bcotrim self-assigned this Sep 22, 2025
@bcotrim bcotrim mentioned this pull request Sep 22, 2025
1 task

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bcotrim ! I have tested it, and I can see the Close icon as white in RTL languagues. LGTM! :shipit:

English Arabic
CleanShot 2025-09-23 at 12 19 08@2x CleanShot 2025-09-23 at 12 19 25@2x
@bcotrim
bcotrim merged commit 05174cc into trunk Sep 23, 2025
12 checks passed
@bcotrim
bcotrim deleted the fix/whats_new_close_button_color branch September 23, 2025 10:24

@sejas sejas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this fixes the color of the close button in the what's new modal when using Vite. I pulled the branch chore/vite_build to test it.

Thanks for fixing the issue. 🙌

Before After
Screenshot 2025-09-23 at 11 30 21 Screenshot 2025-09-23 at 11 30 11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants