Skip to content

blueprints optimize datafiels render - #1806

Merged
bcotrim merged 1 commit into
trunkfrom
fix/blueprints_datafields_render
Sep 23, 2025
Merged

blueprints optimize datafiels render#1806
bcotrim merged 1 commit into
trunkfrom
fix/blueprints_datafields_render

Conversation

@bcotrim

@bcotrim bcotrim commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

  • Adjust some useCallback dependencies to prevent unnecessary re-renders

Testing Instructions

  • Start Studio
  • Add Site -> Blueprints
  • In the blueprint selection page, the thumbnail images should not blink while navigating the screen (selecting different blueprints, selecting from file or remove selected file)

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@bcotrim
bcotrim requested a review from sejas September 22, 2025 18:23
@bcotrim bcotrim self-assigned this Sep 22, 2025
@bcotrim bcotrim mentioned this pull request Sep 22, 2025
Merged
1 task
epeicher
epeicher approved these changes Sep 23, 2025
View reviewed changes

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bcotrim, this is a simple but good optimization, we should always try to use stable references in the React hooks dependency arrays. LGTM!
@bcotrim
bcotrim merged commit 1f911e6 into trunk Sep 23, 2025
12 checks passed
@bcotrim
bcotrim deleted the fix/blueprints_datafields_render branch September 23, 2025 10:27
sejas
sejas reviewed Sep 23, 2025
View reviewed changes

@sejas sejas left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning the code , and reducing renders 👍
I confirm the blinking images are fixed. I also tested it with the chore/vite_build branch.

image-rerenders-fixed.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@bcotrim @sejas @epeicher