Skip to content

Specify explicit fonts to fix issue on MacOS Tahoe - #1838

Merged
wojtekn merged 1 commit into
trunkfrom
fix/font-handling-on-mac-tahoe
Oct 2, 2025
Merged

Specify explicit fonts to fix issue on MacOS Tahoe#1838
wojtekn merged 1 commit into
trunkfrom
fix/font-handling-on-mac-tahoe

Conversation

@wojtekn

@wojtekn wojtekn commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

This update extends the default font-family stack to include emoji and Unicode-friendly fonts. Previously, Hebrew, emoji, and other non-Latin characters rendered as missing glyphs (tofu boxes) due to stricter fallback handling in macOS Tahoe.

With this change, Studio will:

  • Keep a native look with system UI fonts
  • Correctly render emoji across platforms
  • Support broader language coverage via Noto Sans / Arial Unicode MS

Testing Instructions

  1. Start Studio
  2. Create a site
  3. Edit site and add emoji in name
  4. Confirm emoji is displayed in UI
  5. Change language to Hebrew and other non-latin langages
  6. Confirm translations are displayed correctly

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@wojtekn
wojtekn requested a review from a team October 2, 2025 17:54
@wojtekn wojtekn self-assigned this Oct 2, 2025

@bcotrim bcotrim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
But I couldn't replicate the original issue.
Running the updated version works without any regression.

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected. I can see the emojis in the title, but I could not replicate the original issue in trunk as @bcotrim mentions. Anyway, I think these fallbacks are an improvent so approving this.

Image
@epeicher

epeicher commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

I also tested on Windows and I can see the emojis as expected in both trunk and this branch. This screenshot is running this branch:
CleanShot 2025-10-02 at 20 29 14@2x

@wojtekn
wojtekn merged commit 4c85d61 into trunk Oct 2, 2025
12 checks passed
@wojtekn
wojtekn deleted the fix/font-handling-on-mac-tahoe branch October 2, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants