Studio: Ability to cancel the push and pull - #1864
Merged
bcotrim merged 5 commits intoOct 23, 2025
Merged
Conversation
bcotrim
marked this pull request as draft
October 9, 2025 12:53
bcotrim
force-pushed
the
stu-156-studio-ability-to-cancel-the-push-and-pull
branch
2 times, most recently
from
October 16, 2025 22:36
61b5ec7 to
0c15689
Compare
bcotrim
marked this pull request as ready for review
October 16, 2025 22:38
Contributor
📊 Performance Test ResultsComparing 4b09545 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this PR, it is nice to have an ability to cancel sync operations ❤️
I have noticed two issue while testing:
- If you cancel push first and then start pull and cancel it as well, you end up with a weird state:
I think we need to update it to only include that text in relation to the exact operation that was cancelled.
Cancel pullwas slightly overlapping the side of the screen for me:
bcotrim
force-pushed
the
stu-156-studio-ability-to-cancel-the-push-and-pull
branch
from
October 22, 2025 08:49
0c15689 to
99ba314
Compare
katinthehatsite
approved these changes
Oct 23, 2025
bcotrim
deleted the
stu-156-studio-ability-to-cancel-the-push-and-pull
branch
October 23, 2025 10:18
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related issues
Proposed Changes
Testing Instructions
Pre-merge Checklist