Add hover color for links in "Connect site" modal - #1959
Merged
Conversation
Contributor
📊 Performance Test ResultsComparing 07bffe7 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
epeicher
approved these changes
Oct 29, 2025
epeicher
left a comment
Contributor
There was a problem hiding this comment.
Thanks for improving this @fredrikekelund! I have tested it, and I can see the new hover color for the link. LGTM! ![]()
| Before | After |
|---|---|
![]() |
![]() |
Contributor
|
Nice improvement @fredrikekelund ! I tested it and on my local, the hover on the selected item doesn't work correctly:
|
Contributor
Author
|
I've made the non-selected hover color conditional, too. That's the right way to do it, and it fixes the issue you spotted, @wojtekn 👍 |
katinthehatsite
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Related issues
–
Proposed Changes
The site links in the "Connect site" modal didn't previously have a hover color. This made it easier to overlook that every row actually has two clickable areas: the row itself and the site link.
With this PR, the site links now have a blue hover color (same as other links in the app).
Screen.Recording.2025-10-29.at.09.47.22.mov
Testing Instructions
Pre-merge Checklist