Skip to content

Add hover color for links in "Connect site" modal - #1959

Merged
fredrikekelund merged 3 commits into
trunkfrom
f26d/connect-modal-link-hover-color
Oct 30, 2025
Merged

Add hover color for links in "Connect site" modal#1959
fredrikekelund merged 3 commits into
trunkfrom
f26d/connect-modal-link-hover-color

Conversation

@fredrikekelund

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

The site links in the "Connect site" modal didn't previously have a hover color. This made it easier to overlook that every row actually has two clickable areas: the row itself and the site link.

With this PR, the site links now have a blue hover color (same as other links in the app).

Screen.Recording.2025-10-29.at.09.47.22.mov

Testing Instructions

  1. Open the "Connect site" modal from the Sync tab
  2. Ensure that the site links have a hover color and that they are clickable
  3. After selecting a site in the modal, ensure that the site link still has an appropriate color when hovered

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@fredrikekelund
fredrikekelund requested a review from a team October 29, 2025 13:51
@fredrikekelund fredrikekelund self-assigned this Oct 29, 2025
@github-actions

github-actions Bot commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing 07bffe7 vs trunk

site-editor

Metric trunk 07bffe7 Diff Change
load 10227.00 ms 9211.00 ms -1016.00 ms 🟢 -9.9%

site-startup

Metric trunk 07bffe7 Diff Change
siteCreation 20204.00 ms 20335.00 ms +131.00 ms 🔴 0.6%
siteStartup 6018.00 ms 6010.00 ms -8.00 ms 🟢 -0.1%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this @fredrikekelund! I have tested it, and I can see the new hover color for the link. LGTM! :shipit:

Before After
Image Image
@wojtekn

wojtekn commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

Nice improvement @fredrikekelund !

I tested it and on my local, the hover on the selected item doesn't work correctly:

Screenshot 2025-10-29 at 16 54 52 Screenshot 2025-10-29 at 16 58 28
@fredrikekelund

Copy link
Copy Markdown
Contributor Author

I've made the non-selected hover color conditional, too. That's the right way to do it, and it fixes the issue you spotted, @wojtekn 👍

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Color when hovering over the link:

Image

Color when hovering over the link with the selected row:

Image
@fredrikekelund
fredrikekelund merged commit 3d71a51 into trunk Oct 30, 2025
13 checks passed
@fredrikekelund
fredrikekelund deleted the f26d/connect-modal-link-hover-color branch October 30, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants